impl rust Collaboration and Remote API #5773
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emesare
reviewed
Jul 19, 2024
There was a problem hiding this comment.
I got through 18 before I realized how large this PR is.
For actual failures like merge_database a Result type would be nice, however in the absence of an actual error type it is a code smell. If you added just a simple MergeFailed type and attached it I think that would be better. This is pretty subjective so I'm sure others will have differing opinions.
|
It's probably better to leave Although it's not ideal, it's the current API behavior: binaryninja-api/rust/src/metadata.rs Line 284 in 04b58f9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unimplemented and other notes:
BNRemoteFileDownload- Returns the c++std::vectorfrom the core API, but don't provide any way to free it.BNCollaborationSnapshotDownloadSnapshotFile- Returns the c++std::vectorfrom the core API, but don't provide any way to free it.BNRemoteRequest- Parameters are complex c++ types, and no direct way to manage it.BNAnalysisMergeConflictGetPathItem- Implementation with downcast to u64 is unclear.Remote::connect- Not fully implemented because it depends on enterprise and SecretsProvider.Remote- Methods in python preemptively callspull_files/pull_folders/pull_user_permissions/open, but C++ don't. Python was followed.RemoteProject::upload_new_file- Was ported fromremotebrowser.cpp, this file is not public, so I decided not to implement it.